Skip to content

[TSD] docs: Add annotations for ENABLE_DJANGO_ADMIN_SITE feature flag - #26388

Merged
pdpinch merged 1 commit into
openedx:masterfrom
jramnai:tsd-enable_django_admin_site
Feb 6, 2021
Merged

[TSD] docs: Add annotations for ENABLE_DJANGO_ADMIN_SITE feature flag#26388
pdpinch merged 1 commit into
openedx:masterfrom
jramnai:tsd-enable_django_admin_site

Conversation

@jramnai

@jramnai jramnai commented Feb 4, 2021

Copy link
Copy Markdown
Contributor

Description

This PR adds annotations for ENABLE_DJANGO_ADMIN_SITE feature flag.

Supporting information

https://github.com/edx/edx-platform/pull/829

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Feb 4, 2021
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @jramnai! I've created OSPR-5605 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene

natabene commented Feb 4, 2021

Copy link
Copy Markdown
Contributor

@jramnai Thank you for your contribution!

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@BbrSofiane BbrSofiane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@pdpinch This is ready to merge.

@pdpinch
pdpinch merged commit f5ba226 into openedx:master Feb 6, 2021
@openedx-webhooks

Copy link
Copy Markdown

@jramnai 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@pdpinch

pdpinch commented Feb 6, 2021

Copy link
Copy Markdown
Contributor

Thanks again @jramnai and @BbrSofiane !

I have to say, this toggle seems like it should be deprecated and removed to me, but there's a separate process for that.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@jramnai
jramnai deleted the tsd-enable_django_admin_site branch February 9, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants