Skip to content

SE-3690 New default logo is 150px wide - #25889

Closed
samuelallan72 wants to merge 1 commit into
openedx:masterfrom
open-craft:samuel/logo-size
Closed

SE-3690 New default logo is 150px wide#25889
samuelallan72 wants to merge 1 commit into
openedx:masterfrom
open-craft:samuel/logo-size

Conversation

@samuelallan72

@samuelallan72 samuelallan72 commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

The new 'powered by Open edX' logo is wider than the original logo, so this should be updated in the default footers included with edx-platform.

https://github.com/edX/edX-platform/wiki/Powered-by-Open-edX-Logos

JIRA tickets: OSPR-5308

Dependencies: None

Screenshots:

1608076314

Sandbox URL:

(master sandboxes currently broken; please test locally)

Merge deadline: "None"

Testing instructions:

  1. view the footer and verify that the new Powered by Open edX logo is displayed at the dimensions requested in https://github.com/edX/edX-platform/wiki/Powered-by-Open-edX-Logos

Reviewers:

Settings:

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @swalladge! I've created OSPR-5308 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Dec 15, 2020
@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@nedbat

nedbat commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

Thanks, but I've made the adjustments a little differently in #25898

@natabene

Copy link
Copy Markdown
Contributor

@swalladge Is this PR still relevant?

@samuelallan72

Copy link
Copy Markdown
Contributor Author

@natabene no, this has been superceded by #25898 , thanks :)

@samuelallan72
samuelallan72 deleted the samuel/logo-size branch December 17, 2020 07:30
@openedx-webhooks

Copy link
Copy Markdown

@swalladge Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants