Cleanup before adding external grader - #258
Merged
Merged
Conversation
Contributor
Author
|
@dianakhuang @nedbat please review |
Contributor
There was a problem hiding this comment.
It looks like this isn't quite equivalent. there's an extra space in 'lms_key ' and I think you want to look for it in header, not header.has_key.
Contributor
Author
There was a problem hiding this comment.
I don't remember changing that :\ Not only the space is a problem, but the code is invalid ( key not in header.has_key). I'll fix it. Thanks for catching that.
Contributor
|
Other than my few minor comments, looks good. 👍 |
Contributor
|
I think that's all I noticed as well. You'll also have to resolve some conflicts before you can merge. |
added 2 commits
June 25, 2013 13:31
Refactor a bit modx_dispatch
Contributor
Author
|
@dianakhuang is it ok to merge? |
Contributor
|
👍 |
rocha
added a commit
that referenced
this pull request
Jun 25, 2013
Cleanup before adding external grader
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…mber Sort by course number. Simplify university grouping.
aboudreault
pushed a commit
to aboudreault/edx-platform
that referenced
this pull request
Oct 7, 2014
Cohorts rebase
diegomillan
referenced
this pull request
in eduNEXT/edx-platform
Sep 14, 2016
…nicode Fix unicode error for course about sidebar
CrewS
pushed a commit
to CrewS/edx-platform-1
that referenced
this pull request
Jan 17, 2019
lms ecommerce has different user
mbifulco
pushed a commit
to gymnasium/edx-platform
that referenced
this pull request
Jan 29, 2019
…calyptus/bug/accredible-cert-fix Bug fix for accredible API - grades as integers
kiram15
pushed a commit
that referenced
this pull request
Jul 17, 2026
Fixes an issue where users cannot delete their own posts created using the “Post anonymously” option in Discussions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor cleanup of module_render, and xmodule.handle_ajax related functions. It does not add any new features.
It will be followed up by two more PRs for the external grader libraries that replace xqueue. This PR is separate to reduce the amount of noise in the following PRs.