Skip to content

Handle more kinds of bad data in segment events. - #25506

Merged
brianhw merged 1 commit into
masterfrom
brian/fix-segmentio
Nov 3, 2020
Merged

Handle more kinds of bad data in segment events.#25506
brianhw merged 1 commit into
masterfrom
brian/fix-segmentio

Conversation

@brianhw

@brianhw brianhw commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

For DESUPPORT-563.

@brianhw
brianhw force-pushed the brian/fix-segmentio branch from e090a02 to 417f4d6 Compare November 3, 2020 00:15
@brianhw
brianhw force-pushed the brian/fix-segmentio branch from 417f4d6 to e47fc61 Compare November 3, 2020 02:52
@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@pwnage101 pwnage101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Comment thread common/djangoapps/track/views/segmentio.py

@robrap robrap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@brianhw
brianhw merged commit 8916944 into master Nov 3, 2020
@brianhw
brianhw deleted the brian/fix-segmentio branch November 3, 2020 20:04
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants