Conversation
Contributor
Author
|
needs https://github.com/edx/edx-platform/pull/25362 to merge to run container properly with |
mraarif
marked this pull request as ready for review
October 27, 2020 13:56
mraarif
force-pushed
the
BOM-2068
branch
2 times, most recently
from
October 29, 2020 09:46
19d6341 to
b84c13d
Compare
jmbowman
approved these changes
Oct 29, 2020
jmbowman
left a comment
jmbowman
left a comment
Contributor
There was a problem hiding this comment.
Looks good other than the one noted suggestion.
Contributor
There was a problem hiding this comment.
The line above can go away also, although you may need to add software-properties-common back to the list of packages below. See https://github.com/edx/edx-platform/pull/25205/files for the original change.
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.