Skip to content

[Provisional] Access Control Backends plugins - #25339

Closed
OmarIthawi wants to merge 1 commit into
openedx:masterfrom
appsembler:omar/acb-upstream
Closed

[Provisional] Access Control Backends plugins#25339
OmarIthawi wants to merge 1 commit into
openedx:masterfrom
appsembler:omar/acb-upstream

Conversation

@OmarIthawi

Copy link
Copy Markdown
Member

Summary

In late 2019 I’ve proposed a method to customize the access control in Open edX via plugins. This proposal is concerned about augmenting the course load and enroll permissions by providing django app and registering it using the Django settings.

Provisional status of this pull request

Due to timeline complexities, we've chosen to build a Hawthorn-specific implementation that made no use of Birdgekeeper which was introduced in OEP-09 and the permissions ADR.

Due to the timeline issues above the work was merged in our fork: appsembler#491 which enabled us to make the course-access-groups plugin.

I'm opening this pull request to probe the tests and try to see if it works on Juniper.

Next steps

I've opened a thread to discuss how can we streamline the extension point possibly in relation with Bridgekeeper. Let's discuss this on the following topic:

@OmarIthawi

Copy link
Copy Markdown
Member Author

Open edX Team: Could you please run Jenkins on this PR?

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 13, 2020
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @OmarIthawi! I've created OSPR-5055 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@natabene

Copy link
Copy Markdown
Contributor

@OmarIthawi Thank you for your contribution. Please let me know once it is ready for our review.

@OmarIthawi

Copy link
Copy Markdown
Member Author

I'm going to close this PR and open a OEP.

@OmarIthawi OmarIthawi closed this Oct 22, 2020
@OmarIthawi
OmarIthawi deleted the omar/acb-upstream branch October 22, 2020 09:46
@openedx-webhooks openedx-webhooks added rejected and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 22, 2020
@openedx-webhooks

Copy link
Copy Markdown

@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants