Skip to content

[BD-19] applies edx-search lib updates - #25081

Closed
Golub-Sergey wants to merge 7 commits into
openedx:masterfrom
raccoongang:golub-sergey/BD-19/applies-edx-search-lib-updates
Closed

[BD-19] applies edx-search lib updates #25081
Golub-Sergey wants to merge 7 commits into
openedx:masterfrom
raccoongang:golub-sergey/BD-19/applies-edx-search-lib-updates

Conversation

@Golub-Sergey

Copy link
Copy Markdown
Contributor

Description: applies edx-search lib changes to the edx-platform, removes doc_types

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Golub-Sergey! I've created BLENDED-600 to keep track of it in Jira. More details are on the BD-19 project page.

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program community manager review labels Sep 24, 2020
@Golub-Sergey
Golub-Sergey force-pushed the golub-sergey/BD-19/applies-edx-search-lib-updates branch from ab47e85 to 4e03cf0 Compare September 24, 2020 20:00
@Golub-Sergey
Golub-Sergey force-pushed the golub-sergey/BD-19/applies-edx-search-lib-updates branch from 4e03cf0 to 99dc28f Compare September 29, 2020 14:49
Comment thread requirements/edx/github.in Outdated


# Test new version of edx-search
git+https://github.com/raccoongang/edx-search.git@golub-sergey/BD-19/transition-from-ES1.5-to-ES7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git+https://github.com/raccoongang/edx-search.git@golub-sergey/BD-19/transition-from-ES1.5-to-ES7
git+https://github.com/raccoongang/edx-search.git@80980366434e701bc8c0524600bd595e6704b51f

We can lock this to a specific commit (latest in openedx/edx-search#104) for the stage test. Once that looks good, we can cut an edx-search release and switch to using that in edx-platform.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmc-edx Done

@Golub-Sergey
Golub-Sergey force-pushed the golub-sergey/BD-19/applies-edx-search-lib-updates branch from 7380537 to a80e3b9 Compare October 1, 2020 21:22
@Golub-Sergey
Golub-Sergey force-pushed the golub-sergey/BD-19/applies-edx-search-lib-updates branch from a80e3b9 to 3407654 Compare October 1, 2020 21:32
@arch-bom-gocd-alerts

Copy link
Copy Markdown

📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to avoid breaking the build.

We recently removed diff-quality and introduced lint-amnesty. This means that the automated quality check that has run on your branch doesn't work the same way it will on master. If you have introduced any quality failures, they might pass on the PR but then break the build on master.

This branch has been detected to not have commit 2e33565 as an ancestor. Here's how to see for yourself:

git merge-base --is-ancestor 2e335653 golub-sergey/BD-19/applies-edx-search-lib-updates && echo "You're all set" || echo "Please rebase onto master or merge master to your branch"

If you have any questions, please reach out to the Architecture team (either #edx-shared-architecture on Open edX Slack or #architecture on edX internal).

@timmc-edx

Copy link
Copy Markdown
Contributor

This was merged as #25406.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants