Add OAuth2 support for problem response reports endpoints - #24873
Add OAuth2 support for problem response reports endpoints#24873pcockwell wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @pcockwell! I've created OSPR-4933 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@ormsbee Did the investigation for #19635 produce any useful information as the cause of the problems? Could you describe what was happening such that these errors were occurring and/or how to reproduce them? Any information you have on this would be appreciated. Right now, the requests made to these endpoints succeed when providing an |
|
jenkins run all |
xitij2000
left a comment
There was a problem hiding this comment.
Please look at the failing tests and rectify.
ec88404 to
1fa00bf
Compare
|
@pcockwell Thank you for your contribution. Please let me know once it is ready for our review. |
There was a problem hiding this comment.
👍 Seems to be working OK. I've just suggested a few minor corrections and updates. See to them and this is done. Doesn't need another review pass from me.
- I tested this: tested using regular and via instructor dashboard.
- I read through the code
- Includes documentation
There was a problem hiding this comment.
| Assumes that request is in args[0] | |
| Assumes that request is in args[0]. |
There was a problem hiding this comment.
| POST /api/instructor/v1/course/{}/tasks | |
| POST /api/instructor/v1/course/{}/reports |
There was a problem hiding this comment.
Could you update this documentation to also point to the new API endpoints?
xitij2000
left a comment
There was a problem hiding this comment.
👍
- I tested this: tested endpoints using REST requests
- I read through the code
- Includes documentation
d7ed737 to
f82500e
Compare
|
@natabene This is now ready for edX review. Thanks! |
|
jenkins run py38 |
|
@pcockwell Thanks for letting me know, I am lining this up for our review. |
|
jenkins run python-3.8 |
|
@pcockwell If this PR is no longer WIP, could you please update the description to reflect its current status?
|
Done. Sorry about that |
bea09ba to
f54cf80
Compare
|
jenkins run a11y |
2ac60e7 to
5fb1e03
Compare
|
Your PR has finished running tests. The following contexts failed:
|
|
@natabene This can be closed since I've opened a new PR here: https://github.com/edx/edx-platform/pull/27313 |
|
@pcockwell Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR attempts to re-add functionality that was originally included with https://github.com/edx/edx-platform/pull/19635.
JIRA tickets:
OSPR-4933
Sandbox URL: TBD - sandbox is being provisioned.
Testing instructions:
Author notes and concerns:
Reviewers