Skip to content

Add OG title and description to course about pages - #2436

Merged
caesar2164 merged 1 commit into
masterfrom
giulio/add-og-info-about-pages
Feb 3, 2014
Merged

Add OG title and description to course about pages#2436
caesar2164 merged 1 commit into
masterfrom
giulio/add-og-info-about-pages

Conversation

@caesar2164

Copy link
Copy Markdown
Contributor

@singingwolfboy & @adampalay - super quick PR to add OG titles and descriptions to about pages so Facebook and other social media get good content for sharing posts.

@adampalay

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment above these properties that explain these are open graph tags. May be worth additionally linking to https://developers.facebook.com/docs/opengraph/howtos/maximizing-distribution-media-content

@sarina

sarina commented Feb 3, 2014

Copy link
Copy Markdown
Contributor

👍 once this code is self-documenting. I'm worried about other developers, unaware of what the heck og:title means, deleting this code.

@caesar2164

Copy link
Copy Markdown
Contributor Author

@sarina - updated with comment and link.

caesar2164 added a commit that referenced this pull request Feb 3, 2014
Add OG title and description to course about pages
@caesar2164
caesar2164 merged commit 5a722b9 into master Feb 3, 2014
@caesar2164
caesar2164 deleted the giulio/add-og-info-about-pages branch February 3, 2014 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants