Skip to content

Clean up strings in the ErrorModule - #2432

Merged
dianakhuang merged 1 commit into
masterfrom
diana/error-module-i18n
Feb 3, 2014
Merged

Clean up strings in the ErrorModule#2432
dianakhuang merged 1 commit into
masterfrom
diana/error-module-i18n

Conversation

@dianakhuang

Copy link
Copy Markdown
Contributor
  1. Refactor code slightly so that we're only setting a default error_msg at the very end if we don't already have one.
  2. Remove a confusing and unused display_name that has untranslated string

@nedbat @sarina ?

@sarina

sarina commented Feb 3, 2014

Copy link
Copy Markdown
Contributor

👍

1 similar comment
@nedbat

nedbat commented Feb 3, 2014

Copy link
Copy Markdown
Contributor

👍

dianakhuang added a commit that referenced this pull request Feb 3, 2014
Clean up strings in the ErrorModule
@dianakhuang
dianakhuang merged commit 0ee9a72 into master Feb 3, 2014
@dianakhuang
dianakhuang deleted the diana/error-module-i18n branch February 3, 2014 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants