Skip to content

Fix find courses page title in bok choy test suite - #2430

Merged
wedaly merged 1 commit into
masterfrom
will/fix-bok-choy-register-test
Feb 3, 2014
Merged

Fix find courses page title in bok choy test suite#2430
wedaly merged 1 commit into
masterfrom
will/fix-bok-choy-register-test

Conversation

@wedaly

@wedaly wedaly commented Feb 3, 2014

Copy link
Copy Markdown
Contributor

Fixes a bok-choy test that broke with a recent change to master. Got to get these running on every PR :)
@jzoldak

@jzoldak

jzoldak commented Feb 3, 2014

Copy link
Copy Markdown
Contributor

👍
I don't know if this is implemented on the lms side, but on the studio side I defined the page objects using css locators that the design team told me would always indicate that you're on the right page. In general I think we should probably do this where we can rather than using the browser title, which would change if the site was themed, etc.

@wedaly

wedaly commented Feb 3, 2014

Copy link
Copy Markdown
Contributor Author

yeah, I usually do that too -- didn't see anything definitive to check on the main page though.

wedaly pushed a commit that referenced this pull request Feb 3, 2014
Fix find courses page title in bok choy test suite
@wedaly
wedaly merged commit 9fd0fbc into master Feb 3, 2014
@wedaly
wedaly deleted the will/fix-bok-choy-register-test branch February 3, 2014 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants