Skip to content

Pass component display name to Mako template - #2401

Merged
singingwolfboy merged 4 commits into
masterfrom
db/component-label-display-name
Feb 3, 2014
Merged

Pass component display name to Mako template#2401
singingwolfboy merged 4 commits into
masterfrom
db/component-label-display-name

Conversation

@singingwolfboy

Copy link
Copy Markdown
Contributor

No description provided.

@andy-armstrong

Copy link
Copy Markdown
Contributor

👍 Looks great. As we just discussed, I think you need to handle the "Unnamed Component" logic too.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem-editor.py has methods for setting the display name and verifying the display name. Could you reconcile these methods and put them in a shared location?

@cahrens

cahrens commented Feb 3, 2014

Copy link
Copy Markdown

If display_name is None, perhaps use the category like I did for duplicate (also in item.py)? I don't think it is possible for the category to be None.

@marcotuts

Copy link
Copy Markdown
Contributor

PR now includes visual styling adjustments to component header.

@andy-armstrong

Copy link
Copy Markdown
Contributor

👍 This looks really nice with the new design.

@cahrens

cahrens commented Feb 3, 2014

Copy link
Copy Markdown

👍 Do we need anyone to review Marco's changes? Visually it looks good to me, though when your unit is Public it feels like there is a lot of empty white space at the top of the component (although I think this was the case before as well).

@marcotuts

Copy link
Copy Markdown
Contributor

@cahrens - Agreed with the empty white space at the top of the component looking a bit odd, but as this is still the case prior to my changes here, I opted to leave it for now. Hopeful the new container story will help with some of the padding oddness of this page.

singingwolfboy added a commit that referenced this pull request Feb 3, 2014
Pass component display name to Mako template
@singingwolfboy
singingwolfboy merged commit 27b2ff7 into master Feb 3, 2014
@singingwolfboy
singingwolfboy deleted the db/component-label-display-name branch February 3, 2014 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants