Skip to content

Add initial languages, ready for dark-launch - #2388

Merged
cpennington merged 7 commits into
openedx:masterfrom
cpennington:initial-languages
Feb 3, 2014
Merged

Add initial languages, ready for dark-launch#2388
cpennington merged 7 commits into
openedx:masterfrom
cpennington:initial-languages

Conversation

@cpennington

Copy link
Copy Markdown
Contributor

Demo:

  1. localhost:8080
  2. Set language in browser to pt-br (Brazilian Portuguese)
  3. Refresh localhost:8080 (observe no translation)
  4. Visit localhost:8080?preview-lang=pt-br (see Portuguese)
  5. Visit localhost:8080?clear-lang (see English)
  6. Visit localhost:8080/admin, add new Dark Lang Config, add pt-br to the list
  7. Refresh localhost:8080 (see Portuguese)
  8. Visit localhost:8080?preview-lang=ko-kr, navigate to a course (See Course Info is un-reviewed, and thus in English)
  9. Append ?preview-lang=fr to same url (no french translations)

@cpennington

Copy link
Copy Markdown
Contributor Author

@nedbat @sarina: Some changes to be reviewed, plus all of our initial languages, and a demo playbook.

@nedbat

nedbat commented Jan 31, 2014

Copy link
Copy Markdown
Contributor

Thanks.

This checks in conf/locale/eo/LC_MESSAGES/djangojs.prob and conf/local/messages.mo, which it shouldn't. We should .gitignore both of them. IN another PR we can fix the reason the .prob was left around.

Comment thread cms/envs/common.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we import this from lms/envs/common.py, and keep the number of lists down to 2?

@nedbat

nedbat commented Jan 31, 2014

Copy link
Copy Markdown
Contributor

👍

Comment thread conf/locale/config.yaml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth commenting on each of these lines as to what these languages are, for quicker readability for those unfamiliar with language codes? eg

- pt_BR # Portuguese (Brazilian)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I'll also include the actual language code (pt-br) that you'd use for releasing the language.

@sarina

sarina commented Jan 31, 2014

Copy link
Copy Markdown
Contributor

👍

Comment thread lms/envs/common.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the two open parens correct here? Or should it be u'فارسی) ایران)' or u'(فارسی (ایران' ? I'm not sure as I don't know Persian

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nedbat

nedbat commented Feb 3, 2014

Copy link
Copy Markdown
Contributor

👍

Comment thread lms/envs/common.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wikipedia capitalizes Norsk

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I have a change, but don't want to reset the tests.

@sarina

sarina commented Feb 3, 2014

Copy link
Copy Markdown
Contributor

I have no concerns 👍

@nedbat

nedbat commented Feb 3, 2014

Copy link
Copy Markdown
Contributor

Merge it already! 👍

cpennington added a commit that referenced this pull request Feb 3, 2014
Add initial languages, ready for dark-launch
@cpennington
cpennington merged commit a3146cd into openedx:master Feb 3, 2014
@cpennington
cpennington deleted the initial-languages branch February 3, 2014 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants