Add initial languages, ready for dark-launch - #2388
Conversation
|
Thanks. This checks in conf/locale/eo/LC_MESSAGES/djangojs.prob and conf/local/messages.mo, which it shouldn't. We should .gitignore both of them. IN another PR we can fix the reason the .prob was left around. |
There was a problem hiding this comment.
Can't we import this from lms/envs/common.py, and keep the number of lists down to 2?
|
👍 |
There was a problem hiding this comment.
Is it worth commenting on each of these lines as to what these languages are, for quicker readability for those unfamiliar with language codes? eg
- pt_BR # Portuguese (Brazilian)
There was a problem hiding this comment.
Makes sense. I'll also include the actual language code (pt-br) that you'd use for releasing the language.
|
👍 |
…ng from the browser
…ang configuration
There was a problem hiding this comment.
is the two open parens correct here? Or should it be u'فارسی) ایران)' or u'(فارسی (ایران' ? I'm not sure as I don't know Persian
There was a problem hiding this comment.
I c/p this from http://www.localeplanet.com/icu/
|
👍 |
There was a problem hiding this comment.
Yeah. I have a change, but don't want to reset the tests.
|
I have no concerns 👍 |
|
Merge it already! 👍 |
Add initial languages, ready for dark-launch
Demo: