Detached pages from XML courses are set to appropriate descriptor class ... - #2374
Merged
Conversation
Contributor
|
Since you're using XML course fixtures, it's a little difficult to understand the tests. Please add comments explaining the assumptions you're making about the XML course's dates. Otherwise, 👍 |
…ss (LMS-2094) Add tests
Contributor
Author
|
@wedaly , added comments |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Adam/lms2118 bulk email unicode errors
mattdrayer
added a commit
that referenced
this pull request
Jan 31, 2014
Hotfix deployed to Edge Production and Production on 2014-01-31, merging PR to release branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...(LMS-2094)
Add tests
Fixes an issue were detached items from XML courses were being turned into HtmlDescriptors instead of their appropriate category descriptor.
@cpennington , in the course of rebasing, there seem to be other changes to xml.py. Does this look okay?
@wedaly
@singingwolfboy
I'd like to hotfix this branch with the commit from https://github.com/edx/edx-platform/pull/2375, once they are approved