Sysadmin Dashboard ADR - #23697
Conversation
|
Thanks for the pull request, @pdpinch! I've created OSPR-4377 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
openedx-webhooks
added
needs triage
open-source-contribution
|
@pdpinch Thank you for your contribution. Please let me know once all tests are green. |
openedx-webhooks
added
waiting on author
|
jenkins run django-2.2/a11y Not sure how I failed an accessibility test with a .rst file. |
|
jenkins run django-2.2/a11y |
|
jenkins run all |
1 similar comment
|
jenkins run all |
|
@natabene how is a markdown file failing the accessibility test? |
|
@jmbowman Would you happen to know why jenkins/django-2.2/a11y is failing in this specific case? |
|
The Django 2.2 tests were disabled a while ago, I don't think it has actually run again since the original flaky failure you saw. It's fine to just ignore that one, it's no longer required to merge. |
There was a problem hiding this comment.
| course teams to see what may be wrong wit their xml. This is the only view that allows permits access by course | |
| course teams to see what may be wrong with their xml. This is the only view that allows access by course |
There was a problem hiding this comment.
| replicated elsewhere in edx-platform. It coudld be refactored as a pluggable app, but some of it's features rely on | |
| replicated elsewhere in edx-platform. It could be refactored as a pluggable app, but some of it's features rely on |
nasthagiri
left a comment
nasthagiri
left a comment
There was a problem hiding this comment.
@pdpinch Once you squash your commits, I can merge the PR.
|
@pdpinch Ping on this. I'd be happy to merge once you squash the commits. |
267420e to
d952cb2
Compare
|
Thanks @nasthagiri ! |
|
I opened a follow-up ADR at https://github.com/edx/edx-platform/pull/24048 |
|
Your PR has finished running tests. There were no failures. |
|
@pdpinch 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
openedx-webhooks
added
merged
and removed
waiting on author
7 participants
This ADR merely captures the status quote for the Sysadmin Dashboard, an initial step towards migrating its functionality out of edx-platform and into a pluggable app.
A follow-up ADR will serve for discussing what APIs the platform needs to support a pluggable Sysadmin Dashboard.