Skip to content

IndexError in get_combined_rubric fixed. #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waheedahmed wants to merge 2 commits into from
Closed

IndexError in get_combined_rubric fixed. #2366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2048df
IndexError in get_combined_rubric fixed.
waheedahmed Jan 30, 2014
4caa3d0
Added test for get_rubric.
waheedahmed Jan 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/lib/xmodule/xmodule/open_ended_grading_classes/combined_open_ended_modulev1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,7 @@ def get_rubric(self, _data):

contexts = []
rubric_number = self.current_task_number
if self.ready_to_reset:
if self.ready_to_reset and len(self.task_states) > rubric_number + 1:

@symbolist symbolist Feb 24, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this logic. It reads if current_task is the only task look at it otherwise look at current_task+1. Why not look at the current_task always?

rubric_number+=1
response = self.get_last_response(rubric_number)
score_length = len(response['grader_types'])
Expand Down
8 changes: 8 additions & 0 deletions common/lib/xmodule/xmodule/tests/test_combined_open_ended.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,14 @@ def test_state_single(self):
def test_state_pe_single(self):
self.ai_state_success(TEST_STATE_PE_SINGLE, iscore=0, tasks=[self.task_xml2])

def test_get_rubric(self):
self.combinedoe.ready_to_reset = True

response = self.combinedoe.get_rubric({})

# Should be succeeded.
self.assertEqual(response.get("success"), True)


class CombinedOpenEndedModuleConsistencyTest(unittest.TestCase):
"""
Expand Down