Do not hide all the elements of the units with graded problems to anonymous users - #22385
Conversation
|
Thanks for the pull request, @morenol! I've created OSPR-3934 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
openedx-webhooks
added
needs triage
open-source-contribution
68355b0 to
8f9e1fd
Compare
|
@morenol Thank you for your contribution. Please let me know once all tests are green. |
|
jenkins run all |
openedx-webhooks
added
waiting on author
|
Hello @natabene, all tests are green! |
|
@marcotuts Can you give this a quick look? |
openedx-webhooks
added
product review
morenol
changed the title
|
Hello @natabene, any updates on this? |
|
@morenol Sorry, no updates yet. |
|
This can move to engineering review next and should be reviewed eventually by @ormsbee. I have no product feedback on this necessarily. If other work on public views has negated the need for this in the default code im ok to remove but need to double check the implications of this in various cases. Thanks! |
openedx-webhooks
added
awaiting prioritization
and removed
product review
|
Hello, any updates on this? |
|
@morenol Sorry, no updates yet. |
|
jenkins run all |
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
Thank you for your patience. Please rebase (just for a sanity check) and modify your commit message to include some of the context from your PR message. I'll merge after that's done.
8f9e1fd to
3bed4cf
Compare
…users: Right now the units of a public course are hidden if there is at least a graded activity in them. This is done due to a change(edx@69eeca6) that was done before the implementation of public_view mechanism for unenrolled users. Since we use public_view now and by default it restricts the unit rendering for anonymous users we do not need to limit the access at this way for anonymous users.
3bed4cf to
73c6a90
Compare
|
jenkins run all |
|
Tests won't start for some reason. I will try to figure out why tomorrow. |
|
Your PR has finished running tests. There were no failures. |
|
@morenol 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
7 participants
Right now the units of a public course are hidden if there is at least a graded activity in them. This is done because a change that was done before the implementation of public_view mechanism for unenrolled users.
I think that since those components don;t have implemented the public_view, it is safe to do this change.
After this change, this is how it looks a unit with a checkbox component and a video.
How to test:
Current behaviour:
The units with graded component are hidden. Somehow the subsections of the course are broken when it is accessed using the links in course outline
Expected behaviour:
Graded components display a message saying that it is only accessible from enrolled users.