Skip to content

Revert "[BB-873] Support for filters, and multiple roots in problem response reports" - #21323

Merged
DawoudSheraz merged 1 commit into
masterfrom
revert-19781-kshtij/problem-response-multi-root-and-fitler
Aug 9, 2019
Merged

Revert "[BB-873] Support for filters, and multiple roots in problem response reports"#21323
DawoudSheraz merged 1 commit into
masterfrom
revert-19781-kshtij/problem-response-multi-root-and-fitler

Conversation

@DawoudSheraz

@DawoudSheraz DawoudSheraz commented Aug 9, 2019

Copy link
Copy Markdown
Contributor

Reverts edx/edx-platform#19781 as with the merge of that PR, the problem response CSV is broken, with the following error(confirmed locally and at the stage):

edx.devstack.lms     |   File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/celery/app/trace.py", line 240, in trace_task
edx.devstack.lms     |     R = retval = fun(*args, **kwargs)
edx.devstack.lms     |   File "/edx/app/edxapp/edx-platform/lms/djangoapps/instructor_task/tasks.py", line 177, in calculate_problem_responses_csv
edx.devstack.lms     |     return run_main_task(entry_id, task_fn, action_name)
edx.devstack.lms     |   File "/edx/app/edxapp/edx-platform/lms/djangoapps/instructor_task/tasks_helper/runner.py", line 116, in run_main_task
edx.devstack.lms     |     task_progress = task_fcn(entry_id, course_id, task_input, action_name)
edx.devstack.lms     |   File "/edx/app/edxapp/edx-platform/lms/djangoapps/instructor_task/tasks_helper/grades.py", line 778, in generate
edx.devstack.lms     |     usage_key_str_list=problem_locations.split(','),
edx.devstack.lms     | AttributeError: 'NoneType' object has no attribute 'split'

Here is a screenshot from the Splunk for stage error:
er1

@DawoudSheraz
DawoudSheraz requested a review from a team August 9, 2019 12:18
@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@noraiz-anwar noraiz-anwar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DawoudSheraz
DawoudSheraz merged commit 5ac57c2 into master Aug 9, 2019
@DawoudSheraz
DawoudSheraz deleted the revert-19781-kshtij/problem-response-multi-root-and-fitler branch August 9, 2019 12:54
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, August 09, 2019.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants