remove staff exemption from the library_content transformer - #20859
Merged
Conversation
Contributor
Author
|
jenkins run js |
fysheets
approved these changes
Jun 21, 2019
|
@ormsbee Tagging you here as a heads up as you had originally reviewed the PR referenced in Dawoud's comment |
DawoudSheraz
force-pushed
the
dsheraz/prod-136
branch
from
June 24, 2019 06:05
1c39a7d to
b37e679
Compare
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Monday, June 24, 2019. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROD-136
Description
For a randomized library content, it is expected that problems are to be assigned randomly to the users regardless of the type. The user should not be able to access any problem that is not assigned to them. This held true even for the staff members. Initially, this caused problems for the staff members when they tried to generate the problem response CSV for a problem within library content that was not assigned to them. The task would fail with an exception. To cater to that, a fix was done in https://github.com/edx/edx-platform/pull/19798 that added staff as an exemption when transforming the blocks. This fix caused another problem where the progress page of the staff users would show all the problems of the library content regardless if they are assigned to them or not.
After removing the fix that was done, the initial problem didn't happen i.e. if the staff member tried to generate the report for a problem that wasn't assigned to them, the report generated. After further analysis, I came across this PR https://github.com/edx/edx-platform/pull/19507 which was merged shortly after I did the fix. That PR made some enhancements to the problem response csv task and added some checks. This check is the reason that error was no longer happening. In short, we no longer need to keep the staff exemption in the library content.
Reviewers
Post Review