Edit worker type in ironwood Jenkinsfiles - #19875
Merged
michaelyoungstrom merged 1 commit intoFeb 26, 2019
Merged
Conversation
michaelyoungstrom
changed the title
michaelyoungstrom
changed the title
michaelyoungstrom
force-pushed
the
youngstorm/update-jenkinsfile
branch
from
February 25, 2019 21:24
6cbcfad to
ba92641
Compare
michaelyoungstrom
force-pushed
the
youngstorm/update-jenkinsfile
branch
from
February 26, 2019 15:00
ba92641 to
71a824e
Compare
|
Your PR has finished running tests. The following contexts failed:
|
jmbowman
approved these changes
Feb 26, 2019
Contributor
|
Is this something I should do when first making the ironwood.master branch? Or can we avoid editing the files by having them read some configuration? |
Contributor
Author
|
It doesn't look like we can set worker types to be an environment variable, so we need to explicitly edit this on releases. This may change though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ironwood CI should run with its own specific workers.
Bokchoy tests that try and hit the RTD links rightfully fail as we haven't officially released yet.