Skip to content

Fix image mapping in IE #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polesye merged 3 commits into from
Dec 12, 2013
Merged

Fix image mapping in IE #1917

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
418d6fa
BLD-413: Add rounding of coordinates.
polesye Dec 11, 2013
79519b7
Address comments.
polesye Dec 11, 2013
d31268e
Minor changes by Valera.
Dec 11, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions common/lib/xmodule/xmodule/js/src/capa/imageinput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ window.image_input_click = function(id,event){
iidiv = document.getElementById("imageinput_"+id);

@valera-rozuvan valera-rozuvan Dec 11, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file the variables iidiv, pos_x, pos_y, result, cx, and cy are leaked into the global namespace. Make sure that they are declared locally.

pos_x = event.offsetX?(event.offsetX):event.pageX-iidiv.offsetLeft;
pos_y = event.offsetY?(event.offsetY):event.pageY-iidiv.offsetTop;
result = "[" + pos_x + "," + pos_y + "]";
result = "[" + Math.round(pos_x) + "," + Math.round(pos_y) + "]";
cx = (pos_x-15) +"px";
cy = (pos_y-15) +"px" ;
// alert(result);
cy = (pos_y-15) +"px";

document.getElementById("cross_"+id).style.left = cx;
document.getElementById("cross_"+id).style.top = cy;
document.getElementById("cross_"+id).style.visibility = "visible" ;
Expand Down