Bug fix for LaTeX source not saving

[cahrens]

This is an updated version of edx#169. It includes a change Jonah made to make "css_click" more robust so that I do not have to put in waits.

[JonahStanley]

👍
Everything works for me.

[JonahStanley]

Would it be possible to rewrite these steps so it says:
Given I have created a LaTeX Problem
When I edit the High Level Source
Then my change to the High Level Source is persisted
And the High Level Source persists //or something like that

just to follow more closely Given-When-Then

[cahrens]

All the tests pass for me too. @dmitchell here is the pull request. As we discussed, I'm going to merge to master when it opens up, and I'm happy to iterate on these tests if they continue to be flaky on your mac.

[dmitchell]

I still got 2 failures on fasttest..cms
Scenario: Test editing key value
#
cms/djangoapps/contentstore/features/advanced-settings.feature:22
Given I am on the Advanced Course Settings page in Studio
# cms/djangoapps/contentstore/features/a Given I am on the
Advanced Course Settings page in Studio #
cms/djangoapps/contentstore/features/advanced-settings.py:23
When I edit the value of a policy key and save
# cms/djangoapps/contentstore/features/a When I edit the
value of a policy key and save #
cms/djangoapps/contentstore/features/advanced-settings.py:40
Then the policy key value is changed
# cms/djangoapps/contentstore/features/a Then the policy key
value is changed #
cms/djangoapps/contentstore/features/advanced-settings.py:93
Traceback (most recent call last):
File
"/Users/dmitchell/mitx_all/python/lib/python2.7/site-packages/lettuce/core.py",
line 143, in call
ret = self.function(self.step, _args, *_kw)
File
"/Users/dmitchell/mitx_all/edx-platform/cms/djangoapps/contentstore/features/advanced-settings.py",
line 94, in the_policy_key_value_is_changed
assert_equal(get_display_name_value(), '"foo"')
File
"/usr/local/Cellar/python/2.7.3/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 511, in assertEqual
assertion_func(first, second, msg=msg)
File
"/usr/local/Cellar/python/2.7.3/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 504, in _baseAssertEqual
raise self.failureException(msg)
AssertionError: u'"Robot Super Course"' != '"foo"'

Scenario: High Level source is persisted for LaTeX problem (bug STUD-280)
#
cms/djangoapps/contentstore/features/problem-editor.feature:69
Given I have created a LaTeX Problem
# cms/djangoapps/conten Given I have
created a LaTeX Problem
# cms/djangoapps/contentstore/features/problem-editor.py:155
When I edit and compile the High Level Source
# cms/djangoapps/conten When I edit and
compile the High Level Source
# cms/djangoapps/contentstore/features/problem-editor.py:163
Then my change to the High Level Source is persisted
# cms/djangoapps/conten Then my change to
the High Level Source is persisted
# cms/djangoapps/contentstore/features/problem-editor.py:171
And when I view the High Level Source I see my changes
# cms/djangoapps/conten And when I view the
High Level Source I see my changes
# cms/djangoapps/contentstore/features/problem-editor.py:179
Traceback (most recent call last):
File
"/Users/dmitchell/mitx_all/python/lib/python2.7/site-packages/lettuce/core.py",
line 143, in call
ret = self.function(self.step, _args, *_kw)
File
"/Users/dmitchell/mitx_all/edx-platform/cms/djangoapps/contentstore/features/problem-editor.py",
line 181, in high_level_source_in_editor
world.css_find('.launch-latex-compiler').find_by_css('a').click()
File
"/Users/dmitchell/mitx_all/python/lib/python2.7/site-packages/splinter/driver/webdriver/init.py",
line 341, in click
self._element.click()
File
"/Users/dmitchell/mitx_all/python/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 51, in click
self._execute(Command.CLICK_ELEMENT)
File
"/Users/dmitchell/mitx_all/python/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 225, in _execute
return self._parent.execute(command, params)
File
"/Users/dmitchell/mitx_all/python/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 160, in execute
self.error_handler.check_response(response)
File
"/Users/dmitchell/mitx_all/python/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 149, in check_response
raise exception_class(message, screen, stacktrace)
ElementNotVisibleException: Message: u'Element must be displayed to
click'

On Mon, Jun 17, 2013 at 2:18 PM, Christina Roberts <notifications@github.com

wrote:

All the tests pass for me too. @dmitchell https://github.com/dmitchellhere is the pull request. As we discussed, I'm going to merge to master
when it opens up, and I'm happy to iterate on these tests if they continue
to be flaky on your mac.

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/pull/186#issuecomment-19563831
.

[cahrens]

@dmitchell I made a change that should fix the 2nd failure. As far as the first, it makes no sense to me (as other test points that type in the fields pass). The next time you run these tests and encounter a failure, please pull me over so I can actually watch the test run. I think that's the only way I can understand what is going on.