Only write xmodule asset files that have changed - #172
Merged
Conversation
Merged
Rake by default imports all .rake files in the rakelib dir, so we can use that rather than doing our own import loop.
`rake install_prereqs` requires a minimal level of ruby and rake already installed. If it doesn't exist, then print out a helpful message indicating next steps.
The preprocess task requires system and env arguments in order to correctly load up the django environment to preprocess sass files to inject themes. In order for that task to recieve the arguments, all tasks that depend on it also have to accept that same set of arguments. This will all go away once the next evolution of themes arrives, which will remove the preprocessing needed to inject theme names.
When running under watchmedo, coffee doesn't display any useful information when it recompiles a changed file, so we make watchmedo echo that information instead.
xmodule-assets creates coffeescript files in the output directories. On its next run, it used to delete the javascript files compiled from those coffee files. Now it doesn't which should make coffee have to do less work. Fixes LMS-451
Use md5 checksumming to verify that we only write out xmodule asset files whose contents differ from what we are about to write. This minimizes thrashing of the other watchers. Fixes LMS-452
aboudreault
pushed a commit
to aboudreault/edx-platform
that referenced
this pull request
Aug 14, 2014
…-cohorted-course Add inline_discussions_cohorting_default and cohorted_inline_discussions in course settings
rediris
pushed a commit
to gymnasium/edx-platform
that referenced
this pull request
Feb 25, 2021
ficus/develop update ficus/master
Danyal-Faheem
pushed a commit
to Danyal-Faheem/edx-platform
that referenced
this pull request
Jul 15, 2025
Co-authored-by: RahatAli <rahatali@A006-00935.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chrisndodge: This should reduce the amount of CPU thrashing that you're having.
Depends on #185 and #173