Make assets watchers run as singletons - #171
Merged
Merged
Conversation
Merged
|
@cpennington I was out this morning (and Friday afternoon). I may not be able to get to this PR until tomorrow, as I need to fix a critical bug before tomorrow's release. Sorry about the delay. |
Contributor
|
@cpennington - is the the branch for me to test the SASS watcher improvements? |
Contributor
Author
|
Actually, use cale/stabilize-dev-env (which has this, and a few other fixes -Cale On Mon, Jun 17, 2013 at 2:52 PM, marcotuts notifications@github.com wrote:
|
Rake by default imports all .rake files in the rakelib dir, so we can use that rather than doing our own import loop.
`rake install_prereqs` requires a minimal level of ruby and rake already installed. If it doesn't exist, then print out a helpful message indicating next steps.
The preprocess task requires system and env arguments in order to correctly load up the django environment to preprocess sass files to inject themes. In order for that task to recieve the arguments, all tasks that depend on it also have to accept that same set of arguments. This will all go away once the next evolution of themes arrives, which will remove the preprocessing needed to inject theme names.
Previously, multiple copies of the watchers started from the different shells would run simultaneously, which left the possiblity of zombie watchers, increased resource consumption, and incorrect results. This fixes that problem by only starting a watcher if that same command isn't already in the process list. Fixes LMS-499
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Temporary fix to allow pages that inherited the marketing template to display
aboudreault
pushed a commit
to aboudreault/edx-platform
that referenced
this pull request
Aug 14, 2014
…lters-to-users-api ziafazal/api-add-filters-to-users-api
jbau
pushed a commit
that referenced
this pull request
Jan 21, 2015
from Stanford-Online:jrbl/lpl_ungenerated_certs_flag into Stanford-Online:master
CrewS
pushed a commit
to CrewS/edx-platform-1
that referenced
this pull request
Dec 28, 2018
alanoe
pushed a commit
to alanoe/edx-platform
that referenced
this pull request
Mar 28, 2020
…tion (openedx#171) Add a management command to create or update site configuration
alanoe
pushed a commit
to alanoe/edx-platform
that referenced
this pull request
Mar 28, 2020
…onfiguration (openedx#171)" This reverts commit 0822fca.
rediris
pushed a commit
to gymnasium/edx-platform
that referenced
this pull request
Feb 25, 2021
…x/cms-media-root specify media root in CMS and allow http scheme in aws_appsembler by env token
macdiesel
added a commit
to macdiesel/edx-platform
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, multiple copies of the watchers started from the different
shells would run simultaneously, which left the possiblity of zombie
watchers, increased resource consumption, and incorrect results. This
fixes that problem by only starting a watcher if that same command isn't
already in the process list.
Fixes LMS-499
@chrisndodge @cahrens: Can you guys review and test this? It should allow you to run lms and cms together more stably (although there are still other issues that may cause problems).
Depends on #185