Add lti consumer xblock modules to LTI REST endpoints - #14349
Conversation
|
Reviewers: Before this change, when I went to the following url: Hopefully, we will have something different after I update the sandbox. :) |
|
@xcompass @douglashall: After the changes when I navigate to: I'm concerned with |
|
@xcompass @douglashall: At first this looked suspicious, but now I see that So, all looks good. Feel free to add thumbs if you wish. Looks like this will finally be merging shortly. |
|
jenkins run bokchoy |
|
👍 |
dianakhuang
left a comment
There was a problem hiding this comment.
👍 happy to see that the endpoint is working now!
d436961 to
23c61ad
Compare
This allows LTI consumer xblock modules being hocked into get_course_lti_endpoints for discovering LTI result/outcome endpoints.
171e9aa to
4f783bb
Compare
|
Somehow this commit got lost in the shuffle with the consumer upgrade. I am working on it in this new PR: https://github.com/edx/edx-platform/pull/15478 |
This allows LTI consumer xblock modules being hocked into get_course_lti_endpoints for
discovering LTI result/outcome endpoints.
This edx-platform change is required to complete testing of the xblock-lti-consumer upgrade being brought into the platform in this PR: https://github.com/edx/edx-platform/pull/14348
It also replaced the following PR: https://github.com/edx/edx-platform/pull/13639
NOTE: I am going to upgrade the sandbox with this branch.
Sandbox: