[STUD-256] Seems like on chrome when cancel is hit in the file chooser, the 'change...

[chrisndodge]

...d' event is fired and startUpload() was being called. We need to check to see if the upload file is blank and - if so - just return immediately out of the function

[chrisndodge]

Re: testing. Per Jay's comment today that the interns are building out test harnessing around asset uploads, I'll see if I can build on that when it's done. Although the File Upload file picker is not a DOM element (it's a browser modal), so I'm not sure if it can simulate mouse clicking in those tests.

[singingwolfboy]

You're better off using the actual files API: do something like $('.file-input').get(0).files and introspect what you get. It's a much nicer API than what you've hacked together here. :)

[singingwolfboy]

https://developer.mozilla.org/en-US/docs/Using_files_from_web_applications

[chrisndodge]

@singingwolfboy updated API

[singingwolfboy]

Sorry to be pedantic, but files should be a local variable, not a global variable; which means it needs to be prefixed with var.

[cahrens]

I thought I put in a comment, but now I don't see it... Do we know WHY this behavior is happening on Chrome? I like your changes, but I wonder if our selector that is binding the event is incorrect.

[singingwolfboy]

@cahrens: it's happening because the startUpload function is bound to the change event on the <input type="file"> object, which means it will be fired anytime the user does something to change it -- whether or not a file is selected. This is the correct fix -- we just need to be sure that the startUpload function is smart enough to handle the case where a file is not selected.

@chrisndodge Looks good to me!

[cahrens]

👍 But please do follow up on the test.