Sarina/more ins dash - #1195
Conversation
There was a problem hiding this comment.
Outdated comment - my last PR made it so we now do get notifications of success events.
|
Thanks for the comments. I think I've addressed everything that's been pointed out. Underscore is already loaded & there's actually stuff at the bottom of the coffee file to enforce that it is. So, sweet. |
|
🐶 🐱 🌵 🐳 🐙 🎍 💳 💸 🎩 |
|
All looks good to me! |
|
Should this get a changelog entry? |
|
@marcotuts yeah, I thought I had done so in my last PR but apparently had not. |
|
Looks good. Technically, the result that you get from the gettext call is translated, so your variable names are inaccurate -- but that makes no difference to the functionality of this PR. 👍 |
|
@singingwolfboy good point. I changed the names of those vars from |
…-bump MCKIN-8582 Version bump for drag and drop
A few things I forgot in my last PR.
Review: @adampalay @flowerhack
@singingwolfboy can you very quickly verify I did the i18n here correctly?