Fix course enrollment count in instructor dashboard

[rocha]

Fix AN-115

[rocha]

@adampalay @mulby

[mulby]

LGTM 👍

[adampalay]

@rocha, why do we want only to count active users? Why not count all users in the legacy dash?

[rocha]

"Active" in this context means that they are enrolled in the course. The previous query was showing also student who were enrolled at some point, but removed the course for some reason.

The legacy dash contains the correct query. The new dashboard was not using the changes introduced for the payed certificates , which introduced the is_active column. Before it was enough if the user had an entry in the table for the given course.

[adampalay]

Oh, ok, 👍 then, thanks!

[stroilova]

Sorry to bother here --
In the JIRA ticket Adam mentions some caveat about students who have not
yet clicked through their account activation email.

Is that actually a discrepancy? How are we counting those students? Thank
you.

On Mon, Sep 30, 2013 at 12:01 PM, Adam notifications@github.com wrote:

Oh, ok, [image: 👍] then, thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1177#issuecomment-25376171
.

[adampalay]

@stroilova , I made a mistake. Is-active means something different in this context.

[stroilova]

Ah ok. I was concerned for a second there, as none of my queries had
accounted for activation emails. Thank you.

On Mon, Sep 30, 2013 at 12:04 PM, Adam notifications@github.com wrote:

@stroilova https://github.com/stroilova , I made a mistake. Is-active
means something different in this context.

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1177#issuecomment-25376441
.