Remove unused profile name. - #11751
Merged
Merged
Conversation
| @@ -1,272 +0,0 @@ | |||
| // structure stolen from http://briancray.com/posts/javascript-module-pattern | |||
|
|
|||
| var CohortManager = (function ($) { | |||
Author
There was a problem hiding this comment.
I believe this code was from the first version of the cohort manager (in the instructor dashboard). It was written, but this file was left behind.
As far as I can tell, this is the place where profile.name was displayed when users moved between cohorts or were added to a cohort.
Author
Contributor
|
👍 for deleting old JS! |
The profile name requires escaping when displayed. Proactively removing since it is not being used. Also discovered some dead code.
cahrens
force-pushed
the
christina/remove-profile-name
branch
from
March 7, 2016 14:37
d8a6bfb to
2f3e3a5
Compare
Author
|
@robrap please review |
Contributor
|
👍 Thanks for the clean up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profile name requires escaping when displayed. Proactively removing since it is not being used. Also discovered some dead code.