make ENABLE_SHOPPING_CART truly optional - #1174
Merged
Merged
Conversation
Contributor
|
👍 Though I think you might need to rebase to master to make sure the tests pass on Jenkins. |
Contributor
|
👍 |
course_about was throwing 500s if ENABLE_SHOPPING_CART=False
Author
|
tests are passing now, merging. |
jbau
added a commit
that referenced
this pull request
Sep 30, 2013
make ENABLE_SHOPPING_CART truly optional
|
Note that you can add tests for the view function that returns the course about page text. That way you could test that the results are different based on whether or not the shopping cart is enabled. For an example, see /edx-platform/cms/djangoapps/contentstore/tests/test_contentstore.py If that doesn't work, there's always integration tests... It would appear that we don't have integration test coverage for the course about page. |
lgp171188
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
course_about was throwing 500s if MITX_FEATURES['ENABLE_SHOPPING_CART']=False, after the previous PR landed.
@dianakhuang @ormsbee