Skip to content

asadiqbal08-xblock translations initial tests - #11628

Merged
mattdrayer merged 1 commit into
mattdrayer/xblock-translationsfrom
asadiqbal08/xblock_translations_tests
Feb 25, 2016
Merged

asadiqbal08-xblock translations initial tests#11628
mattdrayer merged 1 commit into
mattdrayer/xblock-translationsfrom
asadiqbal08/xblock_translations_tests

Conversation

@asadiqbal08

@asadiqbal08 asadiqbal08 commented Feb 23, 2016

Copy link
Copy Markdown
Contributor

@asadiqbal08
asadiqbal08 force-pushed the asadiqbal08/xblock_translations_tests branch from e23aa0f to 493599b Compare February 23, 2016 15:12
@mattdrayer

mattdrayer commented Feb 24, 2016

Copy link
Copy Markdown
Contributor

jenkins run python

@asadiqbal08

asadiqbal08 commented Feb 24, 2016

Copy link
Copy Markdown
Contributor Author

@mattdrayer there is a test that is failing locally as well, I will look into that.

@mattdrayer

mattdrayer commented Feb 24, 2016

Copy link
Copy Markdown
Contributor

hah, I was just going to look into that -- you should be sleeping :) FYI, I am currently rebasing #11575 onto the latest master and squashing some of the older commits.

@mattdrayer
mattdrayer force-pushed the mattdrayer/xblock-translations branch 2 times, most recently from fa3ca94 to 8d5f86e Compare February 24, 2016 19:25
@mattdrayer
mattdrayer force-pushed the asadiqbal08/xblock_translations_tests branch from 493599b to 92ae8e9 Compare February 24, 2016 19:55
@asadiqbal08
asadiqbal08 force-pushed the asadiqbal08/xblock_translations_tests branch 5 times, most recently from d75413f to d092430 Compare February 25, 2016 12:55
@asadiqbal08

asadiqbal08 commented Feb 25, 2016

Copy link
Copy Markdown
Contributor Author

@mattdrayer I updated this PR, Kindly look into that tests and I hope Jenkins will pass all the tests and then we will merge into parent but We got an email from @benpatterson about jenkins failure behavior.

Thanks

nedbat
nedbat reviewed Feb 25, 2016
View reviewed changes
Comment thread cms/djangoapps/contentstore/tests/test_i18n.py Outdated

@nedbat nedbat Feb 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the test is going to change global state like the current language, then you need an addCleanup in setUp that will restore it. Setting it back inside the test isn't enough because the test won't complete if it fails.

@asadiqbal08 asadiqbal08 Feb 25, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@asadiqbal08
asadiqbal08 force-pushed the asadiqbal08/xblock_translations_tests branch from 5bb0b25 to e2543c7 Compare February 25, 2016 13:41
@mattdrayer

mattdrayer commented Feb 25, 2016

Copy link
Copy Markdown
Contributor

Jenkins is happy -- I'm going to merge this child branch into the main feature branch now.

mattdrayer added a commit that referenced this pull request Feb 25, 2016
@mattdrayer
Merge pull request #11628 from edx/asadiqbal08/xblock_translations_tests
e8c6a58 
asadiqbal08-xblock translations initial tests
@mattdrayer
mattdrayer merged commit e8c6a58 into mattdrayer/xblock-translations Feb 25, 2016
@asadiqbal08
asadiqbal08 deleted the asadiqbal08/xblock_translations_tests branch July 26, 2016 06:31
@baby636 baby636 mentioned this pull request Nov 5, 2022
Open
@baby636 baby636 mentioned this pull request Dec 26, 2022
Open
@sumodgeorge sumodgeorge mentioned this pull request Nov 28, 2023
Open
@sumodgeorge sumodgeorge mentioned this pull request Dec 20, 2023
Open
@sumodgeorge sumodgeorge mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asadiqbal08 @mattdrayer @nedbat