Add accessible labels for forum post body inputs - #1161
Merged
Conversation
Contributor
|
One note here - we're using javascript to build out the dom here including the accessibility labels when I think it makes sense to have those be a part of new_post.html We do this throughout the forums I think, and so it doesn't make sense to slow down this PR for that reason. Just wanted to make sure I noted that the forums relies on javascript building dom structure more heavily than I think it should. |
Contributor
|
👍 Post body now read aloud via chromevox |
gwprice
pushed a commit
that referenced
this pull request
Sep 27, 2013
Add accessible labels for forum post body inputs
iloveagent57
pushed a commit
that referenced
this pull request
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kevinchugh @marcotuts