Move Pearson courseware imports to function level. - #1160
Merged
Conversation
Contributor
|
👍 |
brianhw
added a commit
that referenced
this pull request
Sep 27, 2013
Move Pearson courseware imports to function level.
lgp171188
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Sep 20, 2018
Pb version bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pearson login code makes calls into LMS courseware. This has the unfortunate side effect of importing huge swaths of LMS code that should not be included in a common djangoapp. In lieu of major refactoring or outright removal of Pearson login code, this just moves the offending imports down to where they are pulled in only as needed.
@dianakhuang