make seq tooltips appear on focus - #1157
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
may be addressed already but will want to check cross browser impact of this, ensuring we dont have dotted borders around items unnecessarily.
Contributor
There was a problem hiding this comment.
Apparently, after digging through the history this was a Firefox issue - edx@163eb9d#diff-9196fe3ebe3e4a65e923c197a2999fb8
Contributor
Author
There was a problem hiding this comment.
There's another issue, that in firefox, when you click on a nav tab, the tooltips stay displayed (must be that focus is directed on a click)
ghost
assigned
remove focus from tab when clicked
Contributor
|
Looks good to me. Thanks for adding this in. 👍 |
Contributor
|
👍 |
adampalay
added a commit
that referenced
this pull request
Sep 27, 2013
make seq tooltips appear on focus
Agrendalath
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Oct 9, 2018
Merging dev into integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sequential's nav's tooltips appear on focus
Addresses: https://edx-wiki.atlassian.net/browse/LMS-585
@marcotuts @talbs
@gwprice