Studio homepage escaping

[mushtaqak]

TNL-4006

Make the entire template safe by default.

@robrap Please have a review.

[mushtaqak]

@robrap Does this need a test ? I think not, because test for checking template is safe would have been previously written.

[mushtaqak]

@awaisdar001 @adampalay Please a review

[adampalay]

👍

[robrap]

@mushtaqak The following are the types of changes to look out for as you switch to safe by default:

1. Remove | h in lines like this. Note that Mako shouldn't double escape, but this clean-up will avoid causing confusion regarding why some things are escaped and others are not.
2. Lines like this need to wrap the HTML with the HTML() method from djangolib.markup as documented in the i18n read the docs page.
3. Lines like this should look more like number 2 above, where there is a single call to _() and the HTML is injected as documented in read the docs with the HTML() method.

[mushtaqak]

That is great Robert. I will implement these when I come tomorrow morning :-)

[mushtaqak]

@robrap May you please see

[robrap]

Minor: Mostly we have been doing this on one line:

from openedx.core.djangolib.markup import HTML, ugettext as _

[robrap]

@mushtaqak Getting closer. Please let me know when the final changes are done and when the checks are all passing.

One last issue is if you want to search for ) % and adjust the 2 matches to use the format() syntax, it would be nice to have consistency. Thanks!

[mushtaqak]

@robrap all checks passed, one final pass for review :)

[robrap]

Minor: Other code had a 4 space tab.

[robrap]

👍 It's up to you if you want to fix the minor indent issue. I don't need to re-review. Thank you.