Using display_name_with_default instead of display_name. - #11550
Merged
Conversation
muzaffaryousaf
force-pushed
the
muzaffar/tnl4013
branch
from
February 16, 2016 12:25
26c9291 to
67a88b0
Compare
Author
|
@symbolist @muhammad-ammar Quick look ? |
Contributor
|
@muzaffaryousaf lgtm 👍 |
Contributor
|
@muzaffaryousaf I see two other usages of reading |
Contributor
|
In |
muzaffaryousaf
force-pushed
the
muzaffar/tnl4013
branch
from
February 18, 2016 10:36
67a88b0 to
ef7a3cd
Compare
Author
|
@symbolist we don't need default name at line 27 but i've made the change for other place. |
| """ | ||
| Test that the xblocks data is persisted correctly with display_name=None. | ||
| """ | ||
| ItemFactory.create(parent_location=self.sequential_2.location, category='vertical', display_name=None) |
Contributor
There was a problem hiding this comment.
@muzaffaryousaf We should check there is a valid XBlockCache item for this XBlock.
muzaffaryousaf
force-pushed
the
muzaffar/tnl4013
branch
from
February 19, 2016 11:50
ef7a3cd to
5095224
Compare
Author
|
@symbolist I've addressed your feedback. PTAL. Thanks. |
Contributor
|
👍 once tests pass. |
Contributor
|
@muzaffaryousaf Tests have passed. I am merging so that we can get it into todays RC. |
symbolist
added a commit
that referenced
this pull request
Feb 19, 2016
Using display_name_with_default instead of display_name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TNL-4103