Remove course about 'Overview' link/tab. - #11547
Merged
Merged
Conversation
openedx-webhooks
added
open-source-contribution
Contributor
|
👍 |
openedx-webhooks
added
product review
openedx-webhooks
added
awaiting prioritization
and removed
product review
|
Is there any associated sass that should be deleted? |
|
TNL reviewed this in triage, we are 👍 but would like the author to spend a short amount of time searching for the associated sass and/or JavaScript. It's not clear if those elements still exist in the codebase. |
It looks like in the past there used to be several tabs on the course about page, but the other tabs have been commented out years ago. Having a single tab is pointless and confusing, so remove it.
mtyaka
force-pushed
the
remove-course-about-nav
branch
from
March 10, 2016 10:05
0e7f72a to
3ad0a00
Compare
Contributor
Author
|
Thanks for the review @cahrens, and good idea about removing the associated CSS - I found some CSS that wasn't being used anywhere else and removed it. I also set up a sandbox and added links to the PR description. |
|
Thanks-- looks good! Go ahead and merge. |
mtyaka
added a commit
that referenced
this pull request
Mar 10, 2016
Remove course about 'Overview' link/tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like in the past there used to be several tabs on the course about page, but the other tabs have been commented out years ago. Having a single tab is pointless and confusing, so this PR removes it.
This PR removes the single tab:
Partner information: 3rd party-hosted open edX instance
JIRA ticket: https://openedx.atlassian.net/browse/OSPR-1146
LMS Sandbox: http://pr11547.sandbox.opencraft.com/
Studio Sandbox: http://studio.pr11547.sandbox.opencraft.com/