Add API endpoint for issuing programs certificates - #11541
Merged
Conversation
rlucioni
force-pushed
the
renzo/manual-cert-trigger
branch
4 times, most recently
from
February 16, 2016 21:47
75be793 to
3633db6
Compare
Contributor
Author
|
@jimabramson I've moved the endpoint to the LMS |
|
|
||
| from rest_framework import permissions, status, views | ||
| from rest_framework.response import Response | ||
| from rest_framework.authentication import SessionAuthentication |
Contributor
Author
There was a problem hiding this comment.
You got me! Fixed.
|
@rlucioni LGTM. Is CSRF protection happening by default (under session auth)? I don't see it as a high risk endpoint, but if we need to explicitly enable protection then I believe we should do that. |
Contributor
Author
|
@jimabramson DRF's |
Allows staff users to manually enqueue the task responsible for awarding programs certificates. ECOM-3692.
rlucioni
force-pushed
the
renzo/manual-cert-trigger
branch
from
February 17, 2016 18:52
3633db6 to
619420b
Compare
|
👍 once tests pass. |
rlucioni
pushed a commit
that referenced
this pull request
Feb 17, 2016
Add API endpoint for issuing programs certificates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows staff users to manually enqueue the task responsible for awarding programs certificates. ECOM-3692.
@jimabramson please review.