Add monitoring version of package.json - #11528
Merged
Merged
Conversation
andy-armstrong
force-pushed
the
andya/add-js-monitoring-package
branch
2 times, most recently
from
February 12, 2016 06:04
705d098 to
cc1e59c
Compare
andy-armstrong
force-pushed
the
andya/add-js-monitoring-package
branch
from
February 12, 2016 17:40
cc1e59c to
7a6495c
Compare
Contributor
Author
|
@feanil FYI |
Contributor
|
👍 |
andy-armstrong
added a commit
that referenced
this pull request
Feb 12, 2016
Add monitoring version of package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a version of package.json to be used solely for monitoring by Gemnasium. See the README.md file for details as to the purpose of this. I verified that all of the libraries in this file exist in npm, although some of them are so old that their particular versions are not available. It will be interesting to see whether Gemnasium will be able to deal with this, or whether I'll have to remove those items.
I originally intended to list all the libraries and just comment out the ones that are not available, but unfortunately JSON does not support comments and npm strictly enforces this. So as not to lose this information, I've also added a package.txt file with the raw information about every vendor library I could find, along with versions (where available).
@e0d I'm not sure how best to test this with Gemnasium. Is the simplest thing to do to just merge the commit (upon approval) and see what happens? I'm slightly nervous that it will choke on some of the very old library references.
@e0d @cahrens Please review.
FYI @dan-f @AlasdairSwan @benpatterson