MA-1985 add analytics event to thread/comment vote - #11450
Merged
Conversation
wajeeha-khalid
force-pushed
the
jia/MA-1985
branch
2 times, most recently
from
February 7, 2016 10:39
9631e1d to
3076776
Compare
Contributor
Author
|
@jcdyer @nasthagiri kindly review |
| else: | ||
| context["cc_requester"].unvote(cc_content) | ||
| api_content["vote_count"] -= 1 | ||
| track_voted_event(request, context["course"], cc_content, "up", False if form_value else True) |
Contributor
There was a problem hiding this comment.
Lots of opaque args. Use kwargs instead. request and context are self-documenting, but "up" and the boolean are particularly hard to understand, and cc_content only slightly easier.
Contributor
|
(pass complete) |
wajeeha-khalid
force-pushed
the
jia/MA-1985
branch
2 times, most recently
from
February 10, 2016 13:10
b0d66e6 to
88b3f2d
Compare
Contributor
Author
|
@jcdyer updated |
Contributor
Author
|
@muzaffaryousaf @symbolist @muhammad-ammar need one more reviewer on this |
Contributor
There was a problem hiding this comment.
There are imports for the track functions on line 29. Can you merge this with those?
Contributor
|
@wajeeha-khalid We should add tests to verify that the correct event data is emitted. I see some tests for the other events in |
Contributor
|
@wajeeha-khalid I have completed a pass. |
wajeeha-khalid
force-pushed
the
jia/MA-1985
branch
from
February 11, 2016 16:33
88b3f2d to
7bfda1d
Compare
wajeeha-khalid
force-pushed
the
jia/MA-1985
branch
from
February 11, 2016 17:31
7bfda1d to
72aeb2c
Compare
Contributor
Author
|
jenkins run bokchoy |
Contributor
Author
|
@jcdyer @symbolist incorporated feedback |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
wajeeha-khalid
added a commit
that referenced
this pull request
Feb 12, 2016
MA-1985 add analytics event to thread/comment vote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA-1985 add analytics event to thread/comment vote