Use comments to skip tests instead of a tag - #1143
Merged
Merged
Conversation
Contributor
|
👍 |
wedaly
pushed a commit
that referenced
this pull request
Sep 27, 2013
Use comments to skip tests instead of a tag
cocococosti
pushed a commit
to Pearson-Advance/edx-platform
that referenced
this pull request
Aug 18, 2020
PAE-232 - Updating SGA xblock version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lettuce behaves strangely with "exclude" tags. If you have a scenario marked with two tags:
And you run lettuce with
--tag -skip -tag tag_1(EXCLUDEskip, INCLUDEtag_1), then the scenario will get run. Looking at the code, lettuce seems to handle this inconsistently: if a scenario has just ONE tag, then it will be run only if it satisfies ALL the specified tags.I'm going to submit a PR later to the lettuce project, but until then, the quick fix is to comment out the scenarios instead of relying on
skiptags. This will allow me to correctly shard the tests in the Jenkins cluster.@jzoldak