AC-328 LMS updating heading styles - #11428
Closed
downzer0 wants to merge 3 commits into
Closed
Conversation
|
👍 |
Contributor
Author
|
The Pattern Library work is almost ready to be used within the platform. Does it make sense to wait to continue this work until that time, or is this something that needs to happen sooner? We're just talking presentation here, no functionality. Edit: after discussing this, it makes sense to sync them up now, and then revisit them again later when the PL is included fully in the platform. |
Contributor
Author
|
Closing this PR as I'm going to create a new one that will begin to sync up the pattern library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AC-328
After removing H1s and H2s from the available formatting options in CMS, I needed to adjust the styles of the H3s, H4s, and so on, to use the styles of their higher siblings so things looked like they did before. For example, since using H1 and H2 is unavailable, using an H3 in the editor, should look like an H1 style-wise. There should be no visual differences between what students saw previously and what they see now.
Sandbox
https://clrux-ac-328.sandbox.edx.org
Reviewers