Refactor upload tests and add locked asset tests for registered user - #1138
Merged
Conversation
There was a problem hiding this comment.
Originally I had some test cases around this to make sure the asset is viewable in all 3 conditions (logged in and registered for the course, logged in and not registered, not logged in). I deleted two of them because I didn't think the middleware was really testing them correctly. Now that you have things working, do you want to add back the other two cases?
|
👍 after you address my comments to the extent you think they need to be addressed. :) I don't need to re-review. I ran the test locally and it passed. |
jzoldak
pushed a commit
that referenced
this pull request
Oct 2, 2013
Refactor upload tests and add locked asset tests for registered user
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Sep 16, 2016
…st-playback-status-feature Add unittest for playback status feature openedx#905 openedx#1039 (cherry picked from commit c6f68cb4df178e0e60133afbcb7f21d11badd720) Conflicts: biz/djangoapps/ga_achievement/management/commands/tests/test_update_biz_score_status.py biz/djangoapps/ga_achievement/tests/factories.py
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Sep 16, 2016
Merge pull request openedx#1138 from yokose-ks/develop/cypress/unittest-play…
lgp171188
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Aug 16, 2018
DnD temp version bump
cocococosti
pushed a commit
to Pearson-Advance/edx-platform
that referenced
this pull request
Aug 18, 2020
PAE-178 - Remove ALLOW_ENROLL_STAFF_TO_CCX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cahrens