Skip to content

Fixed test course rerun failing on Chrome - #11263

Merged
raeeschachar merged 1 commit into
masterfrom
raees/chrome-bokchoy-test-course-rerun
Jan 20, 2016
Merged

Fixed test course rerun failing on Chrome#11263
raeeschachar merged 1 commit into
masterfrom
raees/chrome-bokchoy-test-course-rerun

Conversation

@raeeschachar

Copy link
Copy Markdown

No description provided.

@raeeschachar

Copy link
Copy Markdown
Author

@benpatterson @jzoldak
Please review.
Chrome was failing the Rerun button as it wasn't clickable. Added hovering on the button using ActionChains, then clicking on it.
Due to fast test run on Chrome, some clicks were failing, added waits on click_course_rerun and course_run functions

@benpatterson

Copy link
Copy Markdown
Contributor

Great. That test also fails on the firefox upgrade, so I'm wondering if it fixes it there too!

👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that explains what you are doing here and why. E.g. "The 'Re-run course' link doesn't show up until you mouseover that course in the course listing."

@jzoldak

jzoldak commented Jan 19, 2016

Copy link
Copy Markdown
Contributor

That is a tricky UX! Nice job @raeeschachar 👍

@raeeschachar
raeeschachar force-pushed the raees/chrome-bokchoy-test-course-rerun branch from 2d59f2d to d440e20 Compare January 19, 2016 19:20
@raeeschachar

Copy link
Copy Markdown
Author

@jzoldak Thanks :). Good to go?
@benpatterson Great. Let me know too.

@benpatterson

Copy link
Copy Markdown
Contributor

👍 from me

@jzoldak

jzoldak commented Jan 19, 2016

Copy link
Copy Markdown
Contributor

👍 🚀

raeeschachar pushed a commit that referenced this pull request Jan 20, 2016
…erun

Fixed test course rerun failing on Chrome
@raeeschachar
raeeschachar merged commit 536ac77 into master Jan 20, 2016
@benpatterson
benpatterson deleted the raees/chrome-bokchoy-test-course-rerun branch August 2, 2016 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants