Skip to content

disable buttons prototype for legacy and beta instr dash - #1125

Merged
adampalay merged 3 commits into
masterfrom
adam/remove-instr-dash-buttons
Oct 7, 2013
Merged

disable buttons prototype for legacy and beta instr dash#1125
adampalay merged 3 commits into
masterfrom
adam/remove-instr-dash-buttons

Conversation

@adampalay

Copy link
Copy Markdown
Contributor

Disables buttons on the instructor dash that don't work for large courses (>500 here).

Adds a note that these buttons are for smaller courses only, and a subheading that they are disabled for larger courses. The subheading turns red for large courses.

@sarina @flowerhack @marcotuts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line for?

@sarina

sarina commented Sep 25, 2013

Copy link
Copy Markdown
Contributor

Functionally this works but I don't like most of the added text.

Hopefully Marco can add to/augment my comments. Marco, here's a screenshot of what one of these areas looks like (this is a small course):

screen shot 2013-09-25 at 1 07 13 pm

@adampalay

Copy link
Copy Markdown
Contributor Author

@flowerhack and @marcotuts ,

can you take a look?

@flowerhack

Copy link
Copy Markdown
Contributor

This looks good to me.

@sarina

sarina commented Sep 30, 2013

Copy link
Copy Markdown
Contributor

@adampalay can you post some screenshots of what things look like where you've made changes? I think that helps Marco review things faster.

@marcotuts

Copy link
Copy Markdown
Contributor

While that is true, I'll review this now :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to remove all inline styles from this over to the appropriate .scss file, I'll note every instance of that below.

@adampalay

Copy link
Copy Markdown
Contributor Author

some screenshots:
instr-legacy-enrollment
instr-legacy-grades
beta-dash-dd

@sarina

sarina commented Oct 1, 2013

Copy link
Copy Markdown
Contributor

I like it! Maybe add something nice at the end like "Thank you for your patience as we continue working to improve your user experience!" or something.

@adampalay

Copy link
Copy Markdown
Contributor Author

@talbs , thanks for the new sass rules. For some reason, they're not working on the beta dash: https://github.com/edx/edx-platform/blob/0ccf0cd14c9a61cceda7723baf70bbf2de666b9d/lms/templates/instructor/instructor_dashboard_2/data_download.html#L7-L19

Here's a screenshot:
beta-dash-broken-sass

@sarina

sarina commented Oct 3, 2013

Copy link
Copy Markdown
Contributor

👍

@shnayder

shnayder commented Oct 4, 2013

Copy link
Copy Markdown

Can we make these small copy tweaks please:

Note: some of these buttons are known to time out for larger "

  •   "courses. We have temporarily disabled those features for courses "
    
  •          "with more than {max_enrollment} students. We are urgently working on "
    
  •          "fixing this issue. Thank you for your patience as we continue "
    
  •          "working to improve the platform!
    

adampalay and others added 3 commits October 7, 2013 10:11
…Dashboard view

LMS: adds message styling to the separate instructor_2 Sass file
@adampalay

Copy link
Copy Markdown
Contributor Author

@shnayder , updated the message.

@shnayder

shnayder commented Oct 7, 2013

Copy link
Copy Markdown

@adampalay Thanks, looks good.

adampalay added a commit that referenced this pull request Oct 7, 2013
disable buttons for legacy and beta instr dash
@adampalay
adampalay merged commit faf796b into master Oct 7, 2013
@adampalay
adampalay deleted the adam/remove-instr-dash-buttons branch October 7, 2013 17:36
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Aug 25, 2016
pomegranited pushed a commit to open-craft/openedx-platform that referenced this pull request Aug 15, 2018
…bump-eoc-xblock

Update EOC Journal XBlock
cocococosti pushed a commit to Pearson-Advance/edx-platform that referenced this pull request Aug 18, 2020
PE-831 Fix accounactivation email body template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants