Just write the loc name as the key in the policy file

[dmitchell]

Since the only thing that varies per asset location w/in a course is the name, just use that as the key in the policy dict.

@cahrens @jkarni Please review.

Enables export from one course and import into another (also more compatible w/ new Locators)

[cahrens]

Is there any way to unit test the scenario of importing into a new course (ie., something that would have caught the bug)?

[jkarni]

I like the idea! My only worry is Christina's - I suspect there might not be anything within export/import tests that test this.

[dmitchell]

Are there any unit tests which test importing into a different course than
was exported? Seems like a bigger issue, but I'll look at it tomorrow.

On Wed, Sep 25, 2013 at 11:14 AM, jkarni notifications@github.com wrote:

I like the idea! My only worry is Christina's - I suspect there might not
be anything within export/import tests that test this.

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1124#issuecomment-25095120
.

[cahrens]

It looks like test_export_course in test_contentstore exports, deletes that course, then imports. I think that would catch the bug (as long as you can use a different course location when you import).

[jkarni]

Looks good to me. After Christina's merge, a rebase, and a Jenkins checkmark, 👍 .

[dmitchell]

@cahrens please approve (I removed your commits from this history)

[dmitchell]

rewrote test and proved it failed w/o my fix

On Wed, Sep 25, 2013 at 1:16 PM, Christina Roberts <notifications@github.com

wrote:

It looks like test_export_course in test_contentstore exports, deletes
that course, then imports. I think that would catch the bug (as long as you
can use a different course location when you import).

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1124#issuecomment-25106566
.

[cahrens]

👍