Fix for bug BLD-359: Unnecessary focus outline around Video Player. - #1120
Merged
valera-rozuvan merged 1 commit intoSep 25, 2013
Merged
Conversation
ghost
assigned
|
@valera-rozuvan As far as I'm concerned, it doesn't break the new improvements to accessibility and fixes this problem. Tested on Chrome/Safari/Firefox. Good tho merge. |
valera-rozuvan
added a commit
that referenced
this pull request
Sep 25, 2013
…around_video Fix for bug BLD-359: Unnecessary focus outline around Video Player.
valera-rozuvan
deleted the
valera/fix_for_unnecessary_outline_around_video
branch
September 25, 2013 14:00
lgp171188
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Sep 20, 2018
MCKIN-7712: update egg name for DnD to include new v4 changes
iloveagent57
pushed a commit
that referenced
this pull request
Feb 26, 2024
Replaces some of the manual calls to `manage.py migrate` with `make migrate` for more consistency with other IDAs. openedx-unsupported/devstack#1085
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Chrome or Safari, if you click on one of the video controls, a large focus outline will surround the entire div containing the video itself, the controls, and the captions. It disappears when you click outside of that div.
On Firefox, none of this behavior but if you click on the edge of that div, a dotted outline will appear that reaches to the far left of the window, disappearing for a while under the navigation accordeon.
Analysis: This is due to the fact that the main video container now has tabindex set to "-1". We can programmability set focus to it now. Chrome and Safari puts a border around it when some child element receives focus.
Solution: Style the element so that the outline is 0 when the main container receives focus.