Skip to content

Move nose arguments around so that we can run tests with manage.py - #1117

Merged
cpennington merged 1 commit into
openedx:masterfrom
cpennington:manage.py-only-tests
Sep 27, 2013
Merged

Move nose arguments around so that we can run tests with manage.py#1117
cpennington merged 1 commit into
openedx:masterfrom
cpennington:manage.py-only-tests

Conversation

@cpennington

Copy link
Copy Markdown
Contributor

@wedaly, @nedbat: This makes it so that manage.py can run tests the same way rake currently does

@cpennington

Copy link
Copy Markdown
Contributor Author

It might be sensible to make a test_common.py that sets up the common test stuff.

@wedaly

wedaly commented Sep 25, 2013

Copy link
Copy Markdown
Contributor

This looks good, but two questions:

  • How does this interact with the nose configuration in setup.cfg?
  • Should some of these options be applied to the tests in common/lib as well (which uses nose directly instead of through django)?

@cpennington

Copy link
Copy Markdown
Contributor Author
  1. The configuration in setup.cfg is global across all of our tests, rather than being specific to test system (lms vs cms)
  2. The stuff I was moving was already specific to just the django tests. There's probably a separate thing to make it easier to run more of the tests in common (for instance, we might make it so that just running nosetests picks up all of the tests in common, and you only get the django tests by running manage.py)

@wedaly

wedaly commented Sep 25, 2013

Copy link
Copy Markdown
Contributor

👍

Comment thread rakelib/tests.rake Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I don't know how to read ruby, but do we need test_id == ''? Looks like this assigns test_id to "" if test_id is already "". Also, the indentation differs from neighboring lines.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, right you are.

@nedbat

nedbat commented Sep 27, 2013

Copy link
Copy Markdown
Contributor

:+2: (trying out the new process! j/k)

cpennington added a commit that referenced this pull request Sep 27, 2013
Move nose arguments around so that we can run tests with manage.py
@cpennington
cpennington merged commit 3762770 into openedx:master Sep 27, 2013
@cpennington
cpennington deleted the manage.py-only-tests branch September 27, 2013 20:13
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Aug 25, 2016
lgp171188 pushed a commit to open-craft/openedx-platform that referenced this pull request Sep 20, 2018
cocococosti pushed a commit to Pearson-Advance/edx-platform that referenced this pull request Aug 18, 2020
MIGRATION - PE-330 - Allowing the same account to login to multiple sites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants