New XML infrastructure for XBlocks - #1100
Merged
Merged
Conversation
ghost
assigned
Contributor
There was a problem hiding this comment.
We wan't xml modulestore to use this method now, not load_from_xml, so that it will work w/ real XBlocks. So, this method should use load_from_xml, rather than the reverse. (Or load_from_xml should just go away entirely).
Contributor
|
Once |
Contributor
|
👍 still stands. |
…oint names, and simply choosing the first one leads to unpredictability.
nedbat
added a commit
that referenced
this pull request
Oct 1, 2013
New XML infrastructure for XBlocks
rocioar
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jun 25, 2018
iloveagent57
pushed a commit
that referenced
this pull request
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cpennington as we discussed, this has None placeholders for the UsageStore etc, but works for XModules.