Skip to content

Add the ActiveTable and Vector Draw XBlocks to ADVANCED_COMPONENT_TYPES. - #10995

Merged
smarnach merged 1 commit into
openedx:rc/2015-12-16from
open-craft:smarnach/activate-activetable
Dec 15, 2015
Merged

Add the ActiveTable and Vector Draw XBlocks to ADVANCED_COMPONENT_TYPES.#10995
smarnach merged 1 commit into
openedx:rc/2015-12-16from
open-craft:smarnach/activate-activetable

Conversation

@smarnach

Copy link
Copy Markdown
Contributor

These XBlocks have been added to the requirements in #10476 and #10932, respectively. However, we failed to whitelist them.

The client (Davidson College) would like to start using them very soon, so we don't want to wait for the next release and would be greatful if this patch could still be included in the current release.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @smarnach! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?repo=edx%2Fedx-platform&number=10995

@smarnach

Copy link
Copy Markdown
Contributor Author

@sarina It would be great if you could take a quick look at this PR. It's just two lines, and targetting the current RC branch. We would really like to get this in before Christmas. :)

@smarnach

Copy link
Copy Markdown
Contributor Author

@sarina Diana Huang (who is release manager) confirmed on Hipchat that she is fine with this going into the release. I would be really happy if you could give me a +1 by 11 a.m., since Diana will deploy a new version of the RC branch at that time.

@sarina

sarina commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

👍

BTW I was OOO this morning, you could have asked someone else (eg @dianakhuang !!!!) to review.

smarnach added a commit that referenced this pull request Dec 15, 2015
Add the ActiveTable and Vector Draw XBlocks to ADVANCED_COMPONENT_TYPES.
@smarnach
smarnach merged commit dd79a69 into openedx:rc/2015-12-16 Dec 15, 2015
@smarnach

Copy link
Copy Markdown
Contributor Author

@sarina Thanks a lot! It's hard for me to tell whether you or Diana are currently busier. I pinged you, and I would have tried getting hold of people on Hipchat if you wouldn't have replied in time, but you did. :)

@Kelketek
Kelketek deleted the smarnach/activate-activetable branch January 28, 2016 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants